[
https://issues.apache.org/jira/browse/FLINK-9703?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16536859#comment-16536859
]
ASF GitHub Bot commented on FLINK-9703:
---------------------------------------
GitHub user rsltrifork opened a pull request:
https://github.com/apache/flink/pull/6288
[FLINK-9703] [flink-mesos] Expose Prometheus port for TM through Mesos
## What is the purpose of the change
To enable Task Managers, when set up by mesos, to expose a port for
Prometheus monitoring.
## Brief change log
- If "metrics.reporter.prom.port' is configured, make sure mesos assigns
a port for it.
## Verifying this change
*(Please pick either of the following options)*
This change is already covered by existing tests, such as *(please describe
tests)*.
*(or)*
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): no
- The public API, i.e., is any changed class annotated with
`@Public(Evolving)`: no
- The serializers: no
- The runtime per-record code paths (performance sensitive): no
- Anything that affects deployment or recovery: JobManager (and its
components), Checkpointing, Yarn/Mesos, ZooKeeper: yes
- The S3 file system connector: no
## Documentation
- Does this pull request introduce a new feature? no
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/Safetrack/flink FLINK-9703
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/6288.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #6288
----
commit ca55557651ca9164d3611d2dfc3f1ce934a6f9ae
Author: Rune Skou Larsen <rsl@...>
Date: 2018-07-09T11:54:51Z
[FLINK-9703] Expose Prometheus port for TM through Mesos
----
> Mesos does not expose TM Prometheus port
> ----------------------------------------
>
> Key: FLINK-9703
> URL: https://issues.apache.org/jira/browse/FLINK-9703
> Project: Flink
> Issue Type: Bug
> Components: Mesos
> Reporter: Rune Skou Larsen
> Priority: Major
> Labels: pull-request-available
>
> LaunchableMesosWorker makes Mesos expose these ports for a Task Manager:
> {{private static final String[] TM_PORT_KEYS = {}}
> {{ "taskmanager.rpc.port",}}
> {{ "taskmanager.data.port"};}}
> But when running Prometheus Exporter on a TM, another port needs to be
> exposed to make Flink's Prometheos endpoint externally scrapable by the
> Prometheus server. By default this is port 9249, but it is configurable
> according to:
> [https://ci.apache.org/projects/flink/flink-docs-release-1.6/monitoring/metrics.html#prometheus-orgapacheflinkmetricsprometheusprometheusreporter]
>
> My plan is to make a PR, that just adds another config option for mesos, to
> enable custom ports to be exposed in the provisioned TMs.
> I considered carrying parts of the Metrics config into the Mesos code to
> automatically map metrics ports in mesos. But making such a "shortcut"
> between Flink's metrics and mesos modules would probably need some sort of
> integration testing, so I prefer the simple solution of just adding another
> Mesos config option. But comments are welcome.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
