[ 
https://issues.apache.org/jira/browse/FLINK-8558?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16536997#comment-16536997
 ] 

ASF GitHub Bot commented on FLINK-8558:
---------------------------------------

Github user pnowojski commented on a diff in the pull request:

    https://github.com/apache/flink/pull/6264#discussion_r200983274
  
    --- Diff: 
flink-connectors/flink-connector-kafka-0.10/src/main/java/org/apache/flink/streaming/connectors/kafka/Kafka010JsonTableSource.java
 ---
    @@ -32,7 +33,13 @@
     
     /**
      * Kafka {@link StreamTableSource} for Kafka 0.10.
    + *
    + * @deprecated Use the {@link org.apache.flink.table.descriptors.Kafka} 
descriptor together
    + *             with descriptors for schema and format instead. Descriptors 
allow for
    + *             implementation-agnostic definition of tables. See also
    + *             {@link 
org.apache.flink.table.api.TableEnvironment#from(ConnectorDescriptor)}.
      */
    +@Deprecated
    --- End diff --
    
    As we talked offline. I wasn't sure if we could  drop `PublicEvolving` 
classes instead of deprecating them. But if you want to deprecate them for one 
release, it might be better idea to do so. 


> Add unified format interfaces and format discovery
> --------------------------------------------------
>
>                 Key: FLINK-8558
>                 URL: https://issues.apache.org/jira/browse/FLINK-8558
>             Project: Flink
>          Issue Type: New Feature
>          Components: Streaming Connectors
>            Reporter: Timo Walther
>            Assignee: Timo Walther
>            Priority: Major
>              Labels: pull-request-available
>
> In the last release, we introduced a new module {{flink-formats}}. Currently 
> only {{flink-avro}} is located there but we will add more formats such as 
> {{flink-json}}, {{flink-protobuf}}, and so on. For better separation of 
> concerns we want decouple connectors from formats: e.g., remove 
> {{KafkaAvroTableSource}} and {{KafkaJsonTableSource}}.
> A newly introduced {{FormatFactory}} will use Java service loaders to 
> discovery available formats in the classpath (similar to how file systems are 
> discovered now). A {{Format}} will provide a method for converting {{byte[]}} 
> to target record type.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to