Github user tillrohrmann commented on a diff in the pull request:

    https://github.com/apache/flink/pull/6276#discussion_r201016655
  
    --- Diff: 
flink-state-backends/flink-statebackend-rocksdb/src/main/java/org/apache/flink/contrib/streaming/state/RocksDBKeyedStateBackend.java
 ---
    @@ -2579,4 +2604,85 @@ public static RocksIteratorWrapper getRocksIterator(
                ReadOptions readOptions) {
                return new 
RocksIteratorWrapper(db.newIterator(columnFamilyHandle, readOptions));
        }
    +
    +   /**
    +    * Encapsulates the logic and resources in connection with creating 
priority queue state structures.
    +    */
    +   class RocksDBPriorityQueueFactory implements PriorityQueueSetFactory, 
AutoCloseable {
    --- End diff --
    
    Does this need to be an inner class? `RocksDBKeyedStateBackend` is already 
more than 2500 lines long.


---

Reply via email to