[ https://issues.apache.org/jira/browse/FLINK-9785?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16538413#comment-16538413 ]
ASF GitHub Bot commented on FLINK-9785: --------------------------------------- Github user yanghua commented on a diff in the pull request: https://github.com/apache/flink/pull/6291#discussion_r201304267 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/netty/PartitionRequestClientHandler.java --- @@ -164,7 +164,9 @@ public void exceptionCaught(ChannelHandlerContext ctx, Throwable cause) throws E + "that the remote task manager was lost.", remoteAddr, cause); } else { - tex = new LocalTransportException(cause.getMessage(), ctx.channel().localAddress(), cause); + SocketAddress localAddr = ctx.channel().localAddress(); + tex = new LocalTransportException(cause.getMessage() + " (connection to '" + remoteAddr + "')", --- End diff -- the same > Add remote addresses to LocalTransportException instances > --------------------------------------------------------- > > Key: FLINK-9785 > URL: https://issues.apache.org/jira/browse/FLINK-9785 > Project: Flink > Issue Type: Improvement > Components: Network > Affects Versions: 1.5.0, 1.4.2 > Reporter: Nico Kruber > Assignee: Nico Kruber > Priority: Major > Labels: pull-request-available > Fix For: 1.6.0 > > > {{LocalTransportException}} instantiations do not always add the remote > address into the exception message. Having this will ease debugging and make > correlating different log files much easier. > There always is an address associated with these exceptions but it does not > seem like this is used anywhere for now and in that case it is also the local > address (looks like its intended to be the error source's address). -- This message was sent by Atlassian JIRA (v7.6.3#76005)