Github user aljoscha commented on a diff in the pull request:

    https://github.com/apache/flink/pull/6292#discussion_r201340299
  
    --- Diff: 
flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/tasks/OneInputStreamTask.java
 ---
    @@ -93,7 +93,7 @@ public void init() throws Exception {
                                        inputWatermarkGauge);
                }
                
headOperator.getMetricGroup().gauge(MetricNames.IO_CURRENT_INPUT_WATERMARK, 
this.inputWatermarkGauge);
    -           
getEnvironment().getMetricGroup().gauge(MetricNames.IO_CURRENT_INPUT_WATERMARK, 
this.inputWatermarkGauge);
    +           
getEnvironment().getMetricGroup().gauge(MetricNames.IO_CURRENT_INPUT_WATERMARK, 
this.inputWatermarkGauge::getValue);
    --- End diff --
    
    maybe document that we create a wrapping metric because registered metrics 
objects have to be unique


---

Reply via email to