[
https://issues.apache.org/jira/browse/FLINK-9789?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16538625#comment-16538625
]
ASF GitHub Bot commented on FLINK-9789:
---------------------------------------
Github user aljoscha commented on a diff in the pull request:
https://github.com/apache/flink/pull/6292#discussion_r201352126
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/metrics/util/InterceptingTaskMetricGroup.java
---
@@ -0,0 +1,53 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.runtime.metrics.util;
+
+import org.apache.flink.metrics.Metric;
+import org.apache.flink.runtime.metrics.groups.TaskMetricGroup;
+import org.apache.flink.runtime.metrics.groups.UnregisteredMetricGroups;
+
+import java.util.HashMap;
+import java.util.Map;
+
+/**
+ * A {@link TaskMetricGroup} that exposes all registered metrics.
+ */
+public class InterceptingTaskMetricGroup extends
UnregisteredMetricGroups.UnregisteredTaskMetricGroup {
+
+ private Map<String, Metric> intercepted;
+
+ /**
+ * Returns the registered metric for the given name, or null if it was
never registered.
+ *
+ * @param name metric name
+ * @return registered metric for the given name, or null if it was
never registered
+ */
+ public Metric get(String name) {
+ return intercepted.get(name);
--- End diff --
this is also only for testing, right?
> Watermark metrics for an operator&task shadow each other
> --------------------------------------------------------
>
> Key: FLINK-9789
> URL: https://issues.apache.org/jira/browse/FLINK-9789
> Project: Flink
> Issue Type: Bug
> Components: Metrics
> Affects Versions: 1.5.0, 1.6.0
> Reporter: Chesnay Schepler
> Assignee: Chesnay Schepler
> Priority: Blocker
> Labels: pull-request-available
> Fix For: 1.5.2, 1.6.0
>
>
> In FLINK-4812 we reworked the watermark metrics to be exposed for each
> operator.
> In FLINK-9467 we made further modifications to also expose these metrics
> again for tasks.
> In both JIRAs we register a single metric multiple times, for example the
> input watermark metric is registered for both the first operator in the task,
> and the task itself.
> Unfortunately, the metric system assumes metric objects to be unique, as can
> be seen in virtually all reporter implementations as well as the
> MetricQueryService.
> As a result the watermark metrics override each other in the reporter,
> causing only one to be reported, whichever was registered last.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
