Github user twalthr commented on a diff in the pull request:
https://github.com/apache/flink/pull/6264#discussion_r201359834
--- Diff:
flink-libraries/flink-table/src/test/scala/org/apache/flink/table/formats/utils/TestAmbiguousTableFormatFactory.scala
---
@@ -16,22 +16,32 @@
* limitations under the License.
*/
-package org.apache.flink.streaming.connectors.kafka;
+package org.apache.flink.table.formats.utils
-import static
org.apache.flink.table.descriptors.KafkaValidator.CONNECTOR_VERSION_VALUE_010;
+import java.util
+
+import org.apache.flink.table.formats.TableFormatFactory
+import org.apache.flink.types.Row
/**
- * Tests for {@link Kafka010AvroTableSourceFactory}.
- */
-public class Kafka010AvroTableSourceFactoryTest extends
KafkaAvroTableSourceFactoryTestBase {
+ * Table format factory for testing.
+ */
+class TestAmbiguousTableFormatFactory extends TableFormatFactory[Row] {
--- End diff --
This implicit interconnection is on purposes. A similar configuration could
happen in a SQL Client library folder. The `TableFormatFactoryServiceTest`
should fail if they are changed too much. But I added more comments for
implementers. If `TestAmbiguousTableFormatFactory` would extend from
`TestTableFormatFactory` then the class based selection would not work anymore.
---
