[jira] [Commented] (FLINK-9713) Support versioned joins in planning phase

[ASF GitHub Bot (JIRA)]

    [ 
https://issues.apache.org/jira/browse/FLINK-9713?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16538904#comment-16538904
 ] 

ASF GitHub Bot commented on FLINK-9713:
---------------------------------------

GitHub user pnowojski opened a pull request:

    https://github.com/apache/flink/pull/6299

    [FLINK-9713][table][sql] Support versioned join in planning phase

    ## What is the purpose of the change
    
    This PR introduces provides a way to define Table Version Functions in 
Table API and handles Table Version Functions in planning phase for streaming 
(both Table API and SQL). Execution is still not supported.
    
    ## Brief change log
    
    For brief change log please check individual commit messages.
    
    ## Verifying this change
    
    This change adds streaming/batching, sql/table test coverage for versioned 
joins handling in form of `VersionedJoinTest`s.
    
    ## Does this pull request potentially affect one of the following parts:
    
      - Dependencies (does it add or upgrade a dependency): (yes / **no**)
      - The public API, i.e., is any changed class annotated with 
`@Public(Evolving)`: (**yes** / no)
      - The serializers: (yes / **no** / don't know)
      - The runtime per-record code paths (performance sensitive): (yes / 
**no** / don't know)
      - Anything that affects deployment or recovery: JobManager (and its 
components), Checkpointing, Yarn/Mesos, ZooKeeper: (yes / **no** / don't know)
      - The S3 file system connector: (yes / **no** / don't know)
    
    ## Documentation
    
      - Does this pull request introduce a new feature? (**yes** / no)
      - If yes, how is the feature documented? (not applicable / docs / 
**JavaDocs** / not documented)


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/pnowojski/flink enrichment

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/6299.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #6299
    
----
commit 8a6d42823088984bffefd3f31165317018414e9d
Author: Piotr Nowojski <piotr.nowojski@...>
Date:   2018-07-05T17:47:01Z

    [FLINK-9738][table] Provide a way to define Table Version Functions in 
Table API

commit 167b6cf345d22eba4ba215abfb0bcb6542e73983
Author: Piotr Nowojski <piotr.nowojski@...>
Date:   2018-07-05T17:58:05Z

    [hotfix][table] Extract computeCost in FlinkLogicalJoin to base class
    
    This commit can be squashed with a following commit after code review

commit c7481d6e4a01fcc4b6c6d3674fec59f19fe6e4c3
Author: Piotr Nowojski <piotr.nowojski@...>
Date:   2018-07-05T18:02:51Z

    [FLINK-9713][table][sql] Support versioned join in planning phase

----


> Support versioned joins in planning phase
> -----------------------------------------
>
>                 Key: FLINK-9713
>                 URL: https://issues.apache.org/jira/browse/FLINK-9713
>             Project: Flink
>          Issue Type: Sub-task
>          Components: Table API &amp; SQL
>    Affects Versions: 1.5.0
>            Reporter: Piotr Nowojski
>            Assignee: Piotr Nowojski
>            Priority: Major
>              Labels: pull-request-available
>
> Queries like:
> {code:java}
> SELECT 
>   o.amount * r.rate 
> FROM 
>   Orders AS o, 
>   LATERAL TABLE (Rates(o.rowtime)) AS r 
> WHERE o.currency = r.currency{code}
> should evaluate to valid plan with versioned joins plan node.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)