[
https://issues.apache.org/jira/browse/FLINK-9810?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16540343#comment-16540343
]
ASF GitHub Bot commented on FLINK-9810:
---------------------------------------
GitHub user zentol opened a pull request:
https://github.com/apache/flink/pull/6310
[FLINK-9810][rest] Close jar file in JarListHandler
## What is the purpose of the change
Small cleanup in the `JarListHandler` to properly close listed jars, as
otherwise subsequent delete operations could fail.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/zentol/flink 9810
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/6310.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #6310
----
commit d0510735b98f710084c2d835fa325e140f028800
Author: zentol <chesnay@...>
Date: 2018-07-11T16:19:53Z
[FLINK-9810][rest] Close jar file in JarListHandler
----
> JarListHandler does not close opened jars
> -----------------------------------------
>
> Key: FLINK-9810
> URL: https://issues.apache.org/jira/browse/FLINK-9810
> Project: Flink
> Issue Type: Bug
> Components: REST, Webfrontend
> Affects Versions: 1.5.0, 1.4.2, 1.6.0
> Reporter: Chesnay Schepler
> Assignee: Chesnay Schepler
> Priority: Major
> Labels: pull-request-available
> Fix For: 1.4.3, 1.5.1, 1.6.0
>
>
> {code}
> try {
> JarFile jar = new JarFile(f);
> Manifest manifest = jar.getManifest();
> String assemblerClass = null;
> if (manifest != null) {
> assemblerClass =
> manifest.getMainAttributes().getValue(PackagedProgram.MANIFEST_ATTRIBUTE_ASSEMBLER_CLASS);
> if (assemblerClass == null) {
> assemblerClass =
> manifest.getMainAttributes().getValue(PackagedProgram.MANIFEST_ATTRIBUTE_MAIN_CLASS);
> }
> }
> if (assemblerClass != null) {
> classes = assemblerClass.split(",");
> }
> }
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
