Github user yanghua commented on a diff in the pull request:

    https://github.com/apache/flink/pull/6305#discussion_r201908082
  
    --- Diff: 
flink-tests/src/test/java/org/apache/flink/test/checkpointing/EventTimeWindowCheckpointingITCase.java
 ---
    @@ -871,19 +892,40 @@ public IntType(int value) {
                }
        }
     
    -   protected int numElementsPerKey() {
    -           return 300;
    +   private int numElementsPerKey() {
    +           switch (this.stateBackendEnum) {
    +                   case ROCKSDB_FULLY_ASYNC:
    +                   case ROCKSDB_INCREMENTAL:
    +                   case ROCKSDB_INCREMENTAL_ZK:
    +                           return 3000;
    +                   default:
    +                   return 300;
    +           }
        }
     
    -   protected int windowSize() {
    -           return 100;
    +   private int windowSize() {
    +           switch (this.stateBackendEnum) {
    +                   case ROCKSDB_FULLY_ASYNC:
    +                   case ROCKSDB_INCREMENTAL:
    +                   case ROCKSDB_INCREMENTAL_ZK:
    +                           return 1000;
    --- End diff --
    
    change this to a const looks better to me


---

Reply via email to