Github user azagrebin commented on a diff in the pull request:
https://github.com/apache/flink/pull/6308#discussion_r202035286
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/state/SerializationProxiesTest.java
---
@@ -126,11 +131,11 @@ public void
testKeyedBackendSerializationProxyRoundtripWithSerializerSerializati
Assert.assertTrue(serializationProxy.getKeySerializer()
instanceof UnloadableDummyTypeSerializer);
Assert.assertEquals(keySerializer.snapshotConfiguration(),
serializationProxy.getKeySerializerConfigSnapshot());
- for (RegisteredKeyedBackendStateMetaInfo.Snapshot<?, ?> meta :
serializationProxy.getStateMetaInfoSnapshots()) {
- Assert.assertTrue(meta.getNamespaceSerializer()
instanceof UnloadableDummyTypeSerializer);
- Assert.assertTrue(meta.getStateSerializer() instanceof
UnloadableDummyTypeSerializer);
-
Assert.assertEquals(namespaceSerializer.snapshotConfiguration(),
meta.getNamespaceSerializerConfigSnapshot());
-
Assert.assertEquals(stateSerializer.snapshotConfiguration(),
meta.getStateSerializerConfigSnapshot());
+ for (StateMetaInfoSnapshot meta :
serializationProxy.getStateMetaInfoSnapshots()) {
--- End diff --
Change like
`RegisteredKeyedBackendStateMetaInfo.Snapshot<?, ?> meta ->
RegisteredKeyedBackendStateMetaInfo(StateMetaInfoSnapshot)`
and then using original assertions might be more complete version of test.
Also for other meta wrappers in further tests
---
