ASF GitHub Bot commented on FLINK-9762:

Github user tillrohrmann commented on a diff in the pull request:

    --- Diff: 
flink-yarn/src/main/java/org/apache/flink/yarn/YarnResourceManager.java ---
    @@ -473,8 +474,13 @@ private ContainerLaunchContext 
createTaskExecutorLaunchContext(Resource resource
                log.debug("TaskManager configuration: {}", flinkConfig);
    +           Configuration taskManagerConfig = flinkConfig.clone();
    +           if (!flinkConfig.containsKey(CoreOptions.TMP_DIRS_OVERRIDDEN)){
    +                   taskManagerConfig.setString(CoreOptions.TMP_DIRS, "");  
// HACK: emulate removal for the given key
    +           }
    --- End diff --
    Replace with `BootstratpTools#cloneConfiguration(Configuration)` in order 
to reduce code duplication.

> CoreOptions.TMP_DIRS wrongly managed on Yarn
> --------------------------------------------
>                 Key: FLINK-9762
>                 URL: https://issues.apache.org/jira/browse/FLINK-9762
>             Project: Flink
>          Issue Type: Bug
>          Components: YARN
>    Affects Versions: 1.5.0
>            Reporter: Oleksandr Nitavskyi
>            Assignee: vinoyang
>            Priority: Major
>              Labels: pull-request-available
>             Fix For: 1.5.2, 1.6.0
> The issue on Yarn is that it is impossible to have different LOCAL_DIRS on 
> JobManager and TaskManager, despite LOCAL_DIRS value depends on the container.
> The issue is that CoreOptions.TMP_DIRS is configured to the default value 
> during JobManager initialization and added to the configuration object. When 
> TaskManager is launched the appropriate configuration object is cloned with 
> LOCAL_DIRS which makes sense only for Job Manager container. When YARN 
> container with TaskManager from his point of view CoreOptions.TMP_DIRS is 
> always equal either to path in flink.yml or to the or to the LOCAL_DIRS of 
> Job Manager (default behaviour). Is TaskManager’s container do not have an 
> access to another folders, that folders allocated by YARN TaskManager cannot 
> be started.

This message was sent by Atlassian JIRA

Reply via email to