[
https://issues.apache.org/jira/browse/FLINK-9701?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16542039#comment-16542039
]
ASF GitHub Bot commented on FLINK-9701:
---------------------------------------
Github user StefanRRichter commented on a diff in the pull request:
https://github.com/apache/flink/pull/6313#discussion_r202130806
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/state/ttl/StateBackendTestContext.java
---
@@ -0,0 +1,120 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.runtime.state.ttl;
+
+import org.apache.flink.api.common.JobID;
+import org.apache.flink.api.common.state.State;
+import org.apache.flink.api.common.state.StateDescriptor;
+import org.apache.flink.api.common.typeutils.base.StringSerializer;
+import org.apache.flink.runtime.checkpoint.CheckpointOptions;
+import org.apache.flink.runtime.checkpoint.StateObjectCollection;
+import org.apache.flink.runtime.execution.Environment;
+import org.apache.flink.runtime.operators.testutils.DummyEnvironment;
+import org.apache.flink.runtime.state.AbstractKeyedStateBackend;
+import org.apache.flink.runtime.state.CheckpointStorageLocation;
+import org.apache.flink.runtime.state.KeyGroupRange;
+import org.apache.flink.runtime.state.KeyedStateHandle;
+import org.apache.flink.runtime.state.SnapshotResult;
+import org.apache.flink.runtime.state.StateBackend;
+import org.apache.flink.runtime.state.internal.InternalKvState;
+import org.apache.flink.util.Preconditions;
+
+import javax.annotation.Nonnull;
+import javax.annotation.Nullable;
+
+import java.io.IOException;
+import java.util.Collection;
+import java.util.Collections;
+import java.util.concurrent.RunnableFuture;
+
+/** Base class for state backend test context. */
+public abstract class StateBackendTestContext {
+ private final StateBackend stateBackend;
+ private final CheckpointStorageLocation checkpointStorageLocation;
+ private final TtlTimeProvider timeProvider;
+
+ private AbstractKeyedStateBackend<String> keyedStateBackend;
+
+ protected StateBackendTestContext(TtlTimeProvider timeProvider) {
+ this.timeProvider = Preconditions.checkNotNull(timeProvider);
+ this.stateBackend =
Preconditions.checkNotNull(createStateBackend());
+ this.checkpointStorageLocation =
createCheckpointStorageLocation();
+ }
+
+ protected abstract StateBackend createStateBackend();
+
+ private CheckpointStorageLocation createCheckpointStorageLocation() {
+ try {
+ return stateBackend
+ .createCheckpointStorage(new JobID())
+ .initializeLocationForCheckpoint(2L);
+ } catch (IOException e) {
+ throw new RuntimeException("unexpected");
+ }
+ }
+
+ void createAndRestoreKeyedStateBackend() {
+ Environment env = new DummyEnvironment();
+ try {
+ if (keyedStateBackend != null) {
+ keyedStateBackend.dispose();
--- End diff --
There is a problem that the backend is only disposed here and not after
each test, this leads to some native errors when I run the test. I suggest to
give this context a `dispose` method and call it in a `@After` method.
> Activate TTL in state descriptors
> ---------------------------------
>
> Key: FLINK-9701
> URL: https://issues.apache.org/jira/browse/FLINK-9701
> Project: Flink
> Issue Type: Sub-task
> Components: State Backends, Checkpointing
> Reporter: Andrey Zagrebin
> Assignee: Andrey Zagrebin
> Priority: Major
> Labels: pull-request-available
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
