[
https://issues.apache.org/jira/browse/FLINK-9807?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16542671#comment-16542671
]
ASF GitHub Bot commented on FLINK-9807:
---------------------------------------
Github user klion26 commented on a diff in the pull request:
https://github.com/apache/flink/pull/6305#discussion_r202269405
--- Diff:
flink-tests/src/test/java/org/apache/flink/test/checkpointing/EventTimeWindowCheckpointingITCase.java
---
@@ -99,11 +110,21 @@
private AbstractStateBackend stateBackend;
+ @Parameterized.Parameter
+ public StateBackendEnum stateBackendEnum;
+
enum StateBackendEnum {
MEM, FILE, ROCKSDB_FULLY_ASYNC, ROCKSDB_INCREMENTAL,
ROCKSDB_INCREMENTAL_ZK, MEM_ASYNC, FILE_ASYNC
}
- protected abstract StateBackendEnum getStateBackend();
+ @Parameterized.Parameters(name = "statebackend type ={0}")
+ public static Collection<StateBackendEnum> parameter() {
+ return Arrays.asList(MEM, FILE, ROCKSDB_FULLY_ASYNC,
ROCKSDB_INCREMENTAL, ROCKSDB_INCREMENTAL_ZK, MEM_ASYNC, FILE_ASYNC);
--- End diff --
Ok, changed it.
> Improve EventTimeWindowCheckpointITCase&LocalRecoveryITCase with parameterized
> ------------------------------------------------------------------------------
>
> Key: FLINK-9807
> URL: https://issues.apache.org/jira/browse/FLINK-9807
> Project: Flink
> Issue Type: Improvement
> Components: Tests
> Affects Versions: 1.5.0
> Reporter: Congxian Qiu
> Assignee: Congxian Qiu
> Priority: Major
> Labels: pull-request-available
>
> Now, the `AbastractEventTimeWIndowCheckpointITCase` and
> `AbstractLocalRecoveryITCase` need to re-implement for every backend, we can
> improve this by using JUnit parameterized
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
