Github user GJL commented on a diff in the pull request:

    https://github.com/apache/flink/pull/6320#discussion_r202348473
  
    --- Diff: flink-container/docker/build.sh ---
    @@ -0,0 +1,128 @@
    +#!/bin/sh
    +
    
+################################################################################
    +#  Licensed to the Apache Software Foundation (ASF) under one
    +#  or more contributor license agreements.  See the NOTICE file
    +#  distributed with this work for additional information
    +#  regarding copyright ownership.  The ASF licenses this file
    +#  to you under the Apache License, Version 2.0 (the
    +#  "License"); you may not use this file except in compliance
    +#  with the License.  You may obtain a copy of the License at
    +#
    +#      http://www.apache.org/licenses/LICENSE-2.0
    +#
    +#  Unless required by applicable law or agreed to in writing, software
    +#  distributed under the License is distributed on an "AS IS" BASIS,
    +#  WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    +#  See the License for the specific language governing permissions and
    +# limitations under the License.
    
+################################################################################
    +
    +usage() {
    +  cat <<HERE
    +Usage:
    +  build.sh --job-jar <path-to-job-jar> --from-local-dist [--image-name 
<image>]
    +  build.sh --job-jar <path-to-job-jar> --from-archive 
<path-to-dist-archive> [--image-name <image>]
    +  build.sh --job-jar <path-to-job-jar> --from-release --flink-version 
<x.x.x> --hadoop-version <x.x> --scala-version <x.xx> [--image-name <image>]
    +  build.sh --help
    +
    +  If the --image-name flag is not used the built image name will be 
'flink'.
    +HERE
    +  exit 1
    +}
    +
    +while [[ $# -ge 1 ]]
    +do
    +key="$1"
    +  case $key in
    +    --job-jar)
    +    JOB_JAR_PATH="$2"
    +    shift
    +    ;;
    +    --from-local-dist)
    +    FROM_LOCAL="true"
    +    ;;
    +    --from-archive)
    +    FROM_ARCHIVE="$2"
    +    shift
    +    ;;
    +    --from-release)
    +    FROM_RELEASE="true"
    +    ;;
    +    --image-name)
    +    IMAGE_NAME="$2"
    +    shift
    +    ;;
    +    --flink-version)
    +    FLINK_VERSION="$2"
    +    shift
    +    ;;
    +    --hadoop-version)
    +    HADOOP_VERSION="$(echo "$2" | sed 's/\.//')"
    +    shift
    +    ;;
    +    --scala-version)
    +    SCALA_VERSION="$2"
    +    shift
    +    ;;
    +    --kubernetes-certificates)
    +    CERTIFICATES_DIR="$2"
    +    shift
    +    ;;
    +    --help)
    +    usage
    +    ;;
    +    *)
    +    # unknown option
    +    ;;
    +  esac
    +  shift
    +done
    +
    +IMAGE_NAME=${IMAGE_NAME:-flink-job}
    +
    +# TMPDIR must be contained within the working directory so it is part of 
the
    +# Docker context. (i.e. it can't be mktemp'd in /tmp)
    +TMPDIR=_TMP_
    +
    +cleanup() {
    +    rm -rf "${TMPDIR}"
    +}
    +trap cleanup EXIT
    +
    +mkdir -p "${TMPDIR}"
    +
    +JOB_JAR_TARGET="${TMPDIR}/job.jar"
    +cp ${JOB_JAR_PATH} ${JOB_JAR_TARGET}
    +
    +if [ -n "${FROM_RELEASE}" ]; then
    +
    +  [[ -n "${FLINK_VERSION}" ]] && [[ -n "${HADOOP_VERSION}" ]] && [[ -n 
"${SCALA_VERSION}" ]] || usage
    +
    +  FLINK_BASE_URL="$(curl -s 
https://www.apache.org/dyn/closer.cgi\?preferred\=true)flink/flink-${FLINK_VERSION}/"
    +  
FLINK_DIST_FILE_NAME="flink-${FLINK_VERSION}-bin-hadoop${HADOOP_VERSION}-scala_${SCALA_VERSION}.tgz"
    +  CURL_OUTPUT="${TMPDIR}/${FLINK_DIST_FILE_NAME}"
    +
    +  echo "Downloading ${FLINK_DIST_FILE_NAME} from ${FLINK_BASE_URL}"
    +  curl -s ${FLINK_BASE_URL}${FLINK_DIST_FILE_NAME} --output ${CURL_OUTPUT}
    --- End diff --
    
    I think it's a bit surprising that for 1.5.0 the command will fail:
    `build.sh --job-jar ./job.jar --from-release --flink-version 1.5.0 
--hadoop-version 28 --scala-version 2.11`
    `build.sh --job-jar ./job.jar --from-release --flink-version 1.5.1 
--hadoop-version 28 --scala-version 2.11` 


---

Reply via email to