Github user pnowojski commented on a diff in the pull request:

    https://github.com/apache/flink/pull/6323#discussion_r202275530
  
    --- Diff: 
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/factories/TableFactory.scala
 ---
    @@ -21,7 +21,14 @@ package org.apache.flink.table.factories
     import java.util
     
     /**
    -  * Common trait for all properties-based discoverable table factories.
    +  * A factory to create different table-related instances from 
string-based properties. This
    +  * factory is used with Java's Service Provider Interfaces (SPI) for 
discovering. A factory is
    +  * called with a set of normalized properties that describe the desired 
format. The factory allows
    --- End diff --
    
    isn't this comment a bit misleading? 
    
    > that describe the desired format. 
    



---

Reply via email to