[
https://issues.apache.org/jira/browse/FLINK-8858?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16543534#comment-16543534
]
ASF GitHub Bot commented on FLINK-8858:
---------------------------------------
Github user pnowojski commented on a diff in the pull request:
https://github.com/apache/flink/pull/6332#discussion_r202427682
--- Diff:
flink-libraries/flink-sql-client/src/main/java/org/apache/flink/table/client/gateway/local/ProgramDeployer.java
---
@@ -73,7 +86,7 @@ public JobExecutionResult fetchExecutionResult() {
* Deploys a job. Depending on the deployment creates a new job
cluster. It saves the cluster id in
* the result and blocks until job completion.
*/
- private <T> JobExecutionResult deployJob(ExecutionContext<T> context,
JobGraph jobGraph, DynamicResult<T> result) {
+ private <T> void deployJob(ExecutionContext<T> context, JobGraph
jobGraph, Result<T> result) {
--- End diff --
split this method? Extract `if (context.getClusterId() == null)` and `else`
branches to separate methods?
> Add support for INSERT INTO in SQL Client
> -----------------------------------------
>
> Key: FLINK-8858
> URL: https://issues.apache.org/jira/browse/FLINK-8858
> Project: Flink
> Issue Type: Sub-task
> Components: Table API & SQL
> Affects Versions: 1.6.0
> Reporter: Renjie Liu
> Assignee: Timo Walther
> Priority: Major
> Labels: pull-request-available
>
> The current design of SQL Client embedded mode doesn't support long running
> queries. It would be useful for simple jobs that can be expressed in a single
> sql statement if we can submit sql statements stored in files as long running
> queries.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
