[jira] [Commented] (FLINK-5232) Add a Thread default uncaught exception handler on the JobManager

[ASF GitHub Bot (JIRA)]

    [ 
https://issues.apache.org/jira/browse/FLINK-5232?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16544183#comment-16544183
 ] 

ASF GitHub Bot commented on FLINK-5232:
---------------------------------------

GitHub user yanghua opened a pull request:

    https://github.com/apache/flink/pull/6334

    [FLINK-5232] Add a Thread default uncaught exception handler on the 
JobManager

    ## What is the purpose of the change
    
    *This pull request Add a Thread default uncaught exception handler on the 
JobManager*
    
    
    ## Brief change log
    
      - *Add a Thread default uncaught exception handler on the JobManager*
    
    ## Verifying this change
    
    This change is a trivial rework / code cleanup without any test coverage.
    
    ## Does this pull request potentially affect one of the following parts:
    
      - Dependencies (does it add or upgrade a dependency): (yes / **no**)
      - The public API, i.e., is any changed class annotated with 
`@Public(Evolving)`: (yes / **no**)
      - The serializers: (yes / **no** / don't know)
      - The runtime per-record code paths (performance sensitive): (yes / 
**no** / don't know)
      - Anything that affects deployment or recovery: JobManager (and its 
components), Checkpointing, Yarn/Mesos, ZooKeeper: (yes / **no** / don't know)
      - The S3 file system connector: (yes / **no** / don't know)
    
    ## Documentation
    
      - Does this pull request introduce a new feature? (yes / **no**)
      - If yes, how is the feature documented? (not applicable / docs / 
JavaDocs / **not documented**)


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/yanghua/flink FLINK-5232

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/6334.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #6334
    
----
commit 27dec5d60d2e799aeea66013b3da904cec137408
Author: yanghua <yanghua1127@...>
Date:   2018-07-14T11:05:20Z

    [FLINK-5232] Add a Thread default uncaught exception handler on the 
JobManager

----


> Add a Thread default uncaught exception handler on the JobManager
> -----------------------------------------------------------------
>
>                 Key: FLINK-5232
>                 URL: https://issues.apache.org/jira/browse/FLINK-5232
>             Project: Flink
>          Issue Type: Sub-task
>          Components: JobManager
>            Reporter: Stephan Ewen
>            Assignee: vinoyang
>            Priority: Major
>              Labels: pull-request-available
>
> When some JobManager threads die because of uncaught exceptions, we should 
> bring down the JobManager. If a thread dies from an uncaught exception, there 
> is a high chance that the JobManager becomes dysfunctional.
> The only sfae thing is to rely on the JobManager being restarted by YARN / 
> Mesos / Kubernetes / etc.
> I suggest to add this code to the JobManager launch:
> {code}
> Thread.setDefaultUncaughtExceptionHandler(new UncaughtExceptionHandler() {
>     @Override
>     public void uncaughtException(Thread t, Throwable e) {
>         try {
>             LOG.error("Thread {} died due to an uncaught exception. Killing 
> process.", t.getName());
>         } finally {
>             Runtime.getRuntime().halt(-1);
>         }
>     }
> });
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)