[
https://issues.apache.org/jira/browse/FLINK-2425?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14651496#comment-14651496
]
ASF GitHub Bot commented on FLINK-2425:
---------------------------------------
Github user sachingoel0101 commented on the pull request:
https://github.com/apache/flink/pull/952#issuecomment-127139227
> ...have it actually wrap the configuration, and have all the "getX()"
methods delegate to the config,
> while all the "setX()" methods fail with an exception.
That was my earlier solution [which is gone now because I rebased and force
pushed :( ]. You're right though. It'd certainly make the initialization
easier, but adds an additional calling overhead for every getter method [which
are the most frequent. Initialization will be done exactly once]. IMO that's
not a good idea.
>I think that silently failing is not a good idea in this case. Silent
failures always keep people >wondering why things don't behave like they
expect. It needs to fail with an exception here.
That's easy enough! :') I just wasn't sure.
>For the test it is important that it catches the case where someone adds a
method (for example >"setStringArray()") to the base class and does not
override it in the superclass.
The assumption being that any modifiers will be named `set*`?
> Give access to TaskManager config and hostname in the Runtime Environment
> -------------------------------------------------------------------------
>
> Key: FLINK-2425
> URL: https://issues.apache.org/jira/browse/FLINK-2425
> Project: Flink
> Issue Type: Improvement
> Components: TaskManager
> Affects Versions: 0.10
> Reporter: Stephan Ewen
> Assignee: Sachin Goel
> Fix For: 0.10
>
>
> The RuntimeEnvironment (that is used by the operators to access the context)
> should give access to the TaskManager's configuration, to allow to read
> config values.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
