Github user zentol commented on a diff in the pull request:

    https://github.com/apache/flink/pull/6289#discussion_r202631900
  
    --- Diff: flink-end-to-end-tests/test-scripts/test-runner-common.sh ---
    @@ -58,20 +63,32 @@ function run_test {
             fi
         fi
     
    -    if [[ ${exit_code} != 0 ]]; then
    +    if [[ ${exit_code} == 0 ]]; then
    +        cleanup
    +    else
             exit "${exit_code}"
         fi
     }
     
    -# Shuts down the cluster and cleans up all temporary folders and files. 
Make sure to clean up even in case of failures.
    +# Shuts down cluster and reverts changes to cluster configs
    +function cleanup_proc {
    +    shutdown_all
    +    revert_default_config
    +}
    +
    +# Cleans up all temporary folders and files
    +function cleanup_files {
    --- End diff --
    
    function name is too generic, rename to `cleanup_temp_files`


---

Reply via email to