[
https://issues.apache.org/jira/browse/FLINK-9873?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16546290#comment-16546290
]
ASF GitHub Bot commented on FLINK-9873:
---------------------------------------
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/6350#discussion_r202962522
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/CheckpointCoordinator.java
---
@@ -457,13 +457,20 @@ public CheckpointTriggerResult triggerCheckpoint(
Execution[] executions = new Execution[tasksToTrigger.length];
for (int i = 0; i < tasksToTrigger.length; i++) {
Execution ee =
tasksToTrigger[i].getCurrentExecutionAttempt();
- if (ee != null && ee.getState() ==
ExecutionState.RUNNING) {
- executions[i] = ee;
- } else {
+ if (ee == null) {
--- End diff --
according to the `ExecutionVertex` docs this branch shouldn't be necessary
at all, but i kept it in to be safe.
> Log actual state when aborting checkpoint due to task not running
> -----------------------------------------------------------------
>
> Key: FLINK-9873
> URL: https://issues.apache.org/jira/browse/FLINK-9873
> Project: Flink
> Issue Type: Improvement
> Components: State Backends, Checkpointing
> Affects Versions: 1.5.1, 1.6.0
> Reporter: Chesnay Schepler
> Assignee: Chesnay Schepler
> Priority: Major
> Labels: pull-request-available
> Fix For: 1.5.2, 1.6.0
>
>
> Currently, if a checkpoint is triggered while a task s not in a RUNNING state
> the following message is logged:
> {code:java}
> Checkpoint triggering task {} of job {} is not being executed at the
> moment.{code}
> We can improve this message to include the actual task state to help diagnose
> problems.
> This message is also a bit ambiguous, as "being executed" could mean many
> things, from not "RUNNING", to not being "DEPLOYED", or to not existing at
> all.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
