Github user twalthr commented on a diff in the pull request:
https://github.com/apache/flink/pull/6343#discussion_r202982499
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/descriptors/SchematicDescriptor.scala
---
@@ -19,14 +19,17 @@
package org.apache.flink.table.descriptors
/**
- * Common class for all descriptors describing a table sink.
+ * A trait for descriptors that allow to define a format and schema.
*/
-abstract class TableSinkDescriptor extends TableDescriptor {
+trait SchematicDescriptor extends Descriptor {
--- End diff --
`SchematicDescriptor` is used for `ExternalCatalogTable`,
`StreamTableDescriptor`, and `BatchTableDescriptor`. If we add a new level next
to `connector`, `format` (which may happens in the future), we would
immediately get a compile error there.
---