Github user twalthr commented on a diff in the pull request:

    https://github.com/apache/flink/pull/6120#discussion_r203040441
  
    --- Diff: 
flink-runtime/src/test/java/org/apache/flink/runtime/util/JarFileCreatorTest.java
 ---
    @@ -102,15 +104,62 @@ public void TestAnonymousInnerClassTrick4() throws 
Exception {
                jfc.addClass(NestedAnonymousInnerClass.class)
                        .createJarFile();
     
    -           Set<String> ans = new HashSet<String>();
    +           Set<String> ans = new HashSet<>();
                
ans.add("org/apache/flink/runtime/util/jartestprogram/NestedAnonymousInnerClass.class");
                
ans.add("org/apache/flink/runtime/util/jartestprogram/NestedAnonymousInnerClass$1$1.class");
                
ans.add("org/apache/flink/runtime/util/jartestprogram/NestedAnonymousInnerClass$1.class");
                
ans.add("org/apache/flink/runtime/util/jartestprogram/NestedAnonymousInnerClass$A.class");
     
                Assert.assertTrue("Jar file for Anonymous Inner Class is not 
correct", validate(ans, out));
     
    -           out.delete();
    +           Assert.assertTrue(out.delete());
    +   }
    +
    +   @Ignore // this is currently not supported (see FLINK-9520)
    +   @Test
    +   public void testFilterWithMethodReference() throws Exception {
    --- End diff --
    
    No this has never worked. I just noticed this bug when I looked at the 
test. What is this `JarFileCreator` good for actually?


---

Reply via email to