[ 
https://issues.apache.org/jira/browse/FLINK-7251?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16546681#comment-16546681
 ] 

ASF GitHub Bot commented on FLINK-7251:
---------------------------------------

Github user twalthr commented on a diff in the pull request:

    https://github.com/apache/flink/pull/6120#discussion_r203040441
  
    --- Diff: 
flink-runtime/src/test/java/org/apache/flink/runtime/util/JarFileCreatorTest.java
 ---
    @@ -102,15 +104,62 @@ public void TestAnonymousInnerClassTrick4() throws 
Exception {
                jfc.addClass(NestedAnonymousInnerClass.class)
                        .createJarFile();
     
    -           Set<String> ans = new HashSet<String>();
    +           Set<String> ans = new HashSet<>();
                
ans.add("org/apache/flink/runtime/util/jartestprogram/NestedAnonymousInnerClass.class");
                
ans.add("org/apache/flink/runtime/util/jartestprogram/NestedAnonymousInnerClass$1$1.class");
                
ans.add("org/apache/flink/runtime/util/jartestprogram/NestedAnonymousInnerClass$1.class");
                
ans.add("org/apache/flink/runtime/util/jartestprogram/NestedAnonymousInnerClass$A.class");
     
                Assert.assertTrue("Jar file for Anonymous Inner Class is not 
correct", validate(ans, out));
     
    -           out.delete();
    +           Assert.assertTrue(out.delete());
    +   }
    +
    +   @Ignore // this is currently not supported (see FLINK-9520)
    +   @Test
    +   public void testFilterWithMethodReference() throws Exception {
    --- End diff --
    
    No this has never worked. I just noticed this bug when I looked at the 
test. What is this `JarFileCreator` good for actually?


> Merge the flink-java8 project into flink-core
> ---------------------------------------------
>
>                 Key: FLINK-7251
>                 URL: https://issues.apache.org/jira/browse/FLINK-7251
>             Project: Flink
>          Issue Type: Improvement
>          Components: Build System
>            Reporter: Stephan Ewen
>            Assignee: Timo Walther
>            Priority: Major
>              Labels: pull-request-available
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to