[
https://issues.apache.org/jira/browse/FLINK-9849?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16548030#comment-16548030
]
ASF GitHub Bot commented on FLINK-9849:
---------------------------------------
Github user yanghua commented on a diff in the pull request:
https://github.com/apache/flink/pull/6365#discussion_r203440989
--- Diff:
flink-connectors/flink-hbase/src/test/java/org/apache/flink/addons/hbase/example/HBaseWriteStreamExample.java
---
@@ -87,22 +90,22 @@ public void configure(Configuration parameters) {
@Override
public void open(int taskNumber, int numTasks) throws
IOException {
- table = new HTable(conf, "flinkExample");
+ Connection connection =
ConnectionFactory.createConnection(conf);
--- End diff --
Based on [HBase Connection
JavaDoc](https://hbase.apache.org/apidocs/org/apache/hadoop/hbase/client/Connection.html#close--)
it seems the caller should invoke `close` method to release resource? so I
suggest we should close connection in udf's `close` method.
> Upgrade hbase version to 2.0.1 for hbase connector
> --------------------------------------------------
>
> Key: FLINK-9849
> URL: https://issues.apache.org/jira/browse/FLINK-9849
> Project: Flink
> Issue Type: Improvement
> Reporter: Ted Yu
> Assignee: zhangminglei
> Priority: Major
> Labels: pull-request-available
>
> Currently hbase 1.4.3 is used for hbase connector.
> We should upgrade to 2.0.1 which was recently released.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
