[ 
https://issues.apache.org/jira/browse/FLINK-9890?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16548915#comment-16548915
 ] 

ASF GitHub Bot commented on FLINK-9890:
---------------------------------------

GitHub user GJL opened a pull request:

    https://github.com/apache/flink/pull/6368

    [FLINK-9890] Remove obsolete class ResourceManagerConfiguration

    ## What is the purpose of the change
    
    *The configuration values are effectively not used. This commit removes the 
class
    and all its usages.*
    
    
    ## Brief change log
      - *Remove ResourceManagerConfiguration and all its usages.*
    
    ## Verifying this change
    
    This change is a trivial rework / code cleanup without any test coverage.
    
    ## Does this pull request potentially affect one of the following parts:
    
      - Dependencies (does it add or upgrade a dependency): (yes / **no**)
      - The public API, i.e., is any changed class annotated with 
`@Public(Evolving)`: (yes / **no**)
      - The serializers: (yes / **no** / don't know)
      - The runtime per-record code paths (performance sensitive): (yes / 
**no** / don't know)
      - Anything that affects deployment or recovery: JobManager (and its 
components), Checkpointing, Yarn/Mesos, ZooKeeper: (**yes** / no / don't know)
      - The S3 file system connector: (yes / **no** / don't know)
    
    ## Documentation
    
      - Does this pull request introduce a new feature? (yes / **no**)
      - If yes, how is the feature documented? (**not applicable** / docs / 
JavaDocs / not documented)


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/GJL/flink FLINK-9890

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/6368.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #6368
    
----
commit 50e05c436511c84d58561a6909520e28666f7358
Author: gyao <gary@...>
Date:   2018-07-18T14:23:59Z

    [FLINK-9890][Distributed Coordination] Remove obsolete class 
ResourceManagerConfiguration
    
    The configuration values are effectively not used. This commit removes the 
class
    and all its usages.

----


> Remove obsolete Class ResourceManagerConfiguration 
> ---------------------------------------------------
>
>                 Key: FLINK-9890
>                 URL: https://issues.apache.org/jira/browse/FLINK-9890
>             Project: Flink
>          Issue Type: Improvement
>          Components: Distributed Coordination
>    Affects Versions: 1.6.0
>         Environment: Rev: 690bc370e19d8003add4e41c05acfb4dccc662b4
>            Reporter: Gary Yao
>            Assignee: Gary Yao
>            Priority: Major
>              Labels: pull-request-available
>
> The class {{ResourceManagerConfiguration}} is effectively not used, and 
> should be therefore removed to avoid confusion.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to