[
https://issues.apache.org/jira/browse/FLINK-9748?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16548930#comment-16548930
]
ASF GitHub Bot commented on FLINK-9748:
---------------------------------------
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/6342#discussion_r203629175
--- Diff: tools/releasing/create_binary_release.sh ---
@@ -44,6 +44,12 @@ else
SHASUM="sha512sum"
fi
+cd ..
+
+FLINK_DIR=`pwd`
+RELEASE_DIR=${RELEASE_DIR}/tools/releasing/release
--- End diff --
yes!
> create_source_release pollutes flink root directory
> ---------------------------------------------------
>
> Key: FLINK-9748
> URL: https://issues.apache.org/jira/browse/FLINK-9748
> Project: Flink
> Issue Type: Improvement
> Components: Release System
> Affects Versions: 1.5.0, 1.6.0
> Reporter: Chesnay Schepler
> Assignee: Chesnay Schepler
> Priority: Major
> Labels: pull-request-available
>
> The {{create_source_release.sh}} moves generated files into the root
> directory of the flink repository, and also creates the flink-clone in this
> directory.
> It would be nicer if these files were placed under a dedicated directory (say
> releasing/release).
> This would prevent file to prevent release files from accidentally being
> committed by adding this directory to the {{.gitignore}} file, and makes it
> easier to cleanup a failed release attempt by actually making it obvious
> which files belong to the release.
> I already implemented these changes in the {{flink-shaded}} release scripts.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
