Github user aljoscha commented on a diff in the pull request:
https://github.com/apache/flink/pull/6376#discussion_r203976558
--- Diff:
flink-tests/src/test/java/org/apache/flink/test/checkpointing/EventTimeAllWindowCheckpointingITCase.java
---
@@ -88,20 +80,17 @@ public void testTumblingTimeWindow() {
final int numElementsPerKey = 3000;
final int windowSize = 100;
final int numKeys = 1;
- FailingSource.reset();
try {
StreamExecutionEnvironment env =
StreamExecutionEnvironment.getExecutionEnvironment();
env.setParallelism(PARALLELISM);
env.setStreamTimeCharacteristic(TimeCharacteristic.EventTime);
env.enableCheckpointing(100);
-
env.setRestartStrategy(RestartStrategies.fixedDelayRestart(3, 0));
+
env.setRestartStrategy(RestartStrategies.fixedDelayRestart(1, 0));
env.getConfig().disableSysoutLogging();
env
- .addSource(new FailingSource(numKeys,
- numElementsPerKey,
- numElementsPerKey / 3))
+ .addSource(new FailingSource(new
EventTimeWindowCheckpointingITCase.KeyedEventTimeGenerator(numKeys,
windowSize), numElementsPerKey))
--- End diff --
Reusing the small helper funs from other tests to me always seems
problematic when the names of that test changes or when the functions change.
Duplicating them here will duplicate code but in the long run is probably
better. WDYT?
---
