GitHub user tillrohrmann opened a pull request:
https://github.com/apache/flink/pull/6384
Remove conjunct future cancellation
## What is the purpose of the change
If a ConjunctFuture is cancelled, then it won't cancel all of its input
futures automatically. If the users needs this behaviour then he has to
implement it explicitly. The reason for this change is that an implicit
cancellation can have unwanted side effects, because all of the cancelled
input futures' producers won't be executed.
This PR is based on #6383.
## Verifying this change
- Trivial change
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (no)
- The public API, i.e., is any changed class annotated with
`@Public(Evolving)`: (no)
- The serializers: (no)
- The runtime per-record code paths (performance sensitive): (no)
- Anything that affects deployment or recovery: JobManager (and its
components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)
- The S3 file system connector: (no)
## Documentation
- Does this pull request introduce a new feature? (no)
- If yes, how is the feature documented? (not applicable)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/tillrohrmann/flink
removeConjunctFutureCancellation
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/6384.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #6384
----
commit f85ec37cc3ad21998eabad45a6dcb46e8efc62fb
Author: Till Rohrmann <trohrmann@...>
Date: 2018-07-19T11:07:44Z
[FLINK-9838][logging] Don't log slot request failures on the ResourceManager
commit 7c703fb3b350ef5b02b01d621c3a16d4bca6f707
Author: Till Rohrmann <trohrmann@...>
Date: 2018-07-19T11:41:03Z
[hotfix] Improve logging of SlotPool and SlotSharingManager
commit 414a8d231a5b6cdc2d5db0c1d35a79ff584c1cd0
Author: Till Rohrmann <trohrmann@...>
Date: 2018-07-22T18:05:05Z
[FLINK-9908][scheduling] Do not cancel individual scheduling future
Since the individual scheduling futures contain logic to release the slot
if it cannot
be assigned to the Execution, we must not cancel them. Otherwise we might
risk that
slots are not returned to the SlotPool leaving it in an inconsistent state.
commit 8f4471339db3a2df01c1cc61e03eb0881f98dd4f
Author: Till Rohrmann <trohrmann@...>
Date: 2018-07-22T18:17:11Z
[FLINK-9909][core] ConjunctFuture does not cancel input futures
If a ConjunctFuture is cancelled, then it won't cancel all of its input
futures automatically. If the users needs this behaviour then he has to
implement it explicitly. The reason for this change is that an implicit
cancellation can have unwanted side effects, because all of the cancelled
input futures' producers won't be executed.
commit c606145182c0531a8239decdc52ceeccdb81ca73
Author: Till Rohrmann <trohrmann@...>
Date: 2018-07-22T18:20:53Z
[hotfix] Fix checkstyle violations in FutureUtils
----
---
