[
https://issues.apache.org/jira/browse/FLINK-6222?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16552416#comment-16552416
]
ASF GitHub Bot commented on FLINK-6222:
---------------------------------------
GitHub user dawidwys opened a pull request:
https://github.com/apache/flink/pull/6388
[FLINK-6222] Allow passing env variables to start scripts via
Added possibility to pass env variables (e.g. HADOOP_CONF_DIR) through
flink-env.sh
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/dawidwys/flink FLINK-6222
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/6388.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #6388
----
commit 7f700d36f2057b38a4ec8873444c3f488447e241
Author: Dawid Wysakowicz <dwysakowicz@...>
Date: 2018-07-19T13:36:56Z
[FLINK-6222] Allow passing env variables to start scripts via
flink-env.sh
----
> YARN: setting environment variables in an easier fashion
> --------------------------------------------------------
>
> Key: FLINK-6222
> URL: https://issues.apache.org/jira/browse/FLINK-6222
> Project: Flink
> Issue Type: Improvement
> Components: Startup Shell Scripts
> Affects Versions: 1.2.0
> Environment: YARN, EMR
> Reporter: Craig Foster
> Assignee: Dawid Wysakowicz
> Priority: Major
> Labels: pull-request-available
> Attachments: patch0-add-yarn-hadoop-conf.diff
>
>
> Right now we require end-users to set YARN_CONF_DIR or HADOOP_CONF_DIR and
> sometimes FLINK_CONF_DIR.
> For example, in [1], it is stated:
> “Please note that the Client requires the YARN_CONF_DIR or HADOOP_CONF_DIR
> environment variable to be set to read the YARN and HDFS configuration.”
> In BigTop, we set this with /etc/flink/default and then a wrapper is created
> to source that. However, this is slightly cumbersome and we don't have a
> central place within the Flink project itself to source environment
> variables. config.sh could do this but it doesn't have information about
> FLINK_CONF_DIR. For YARN and Hadoop variables, I already have a solution that
> would add "env.yarn.confdir" and "env.hadoop.confdir" variables to the
> flink-conf.yaml file and then we just symlink /etc/lib/flink/conf/ and
> /etc/flink/conf.
> But we could also add a flink-env.sh file to set these variables and decouple
> them from config.sh entirely.
> I'd like to know the opinion/preference of others and what would be more
> amenable.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
