[ 
https://issues.apache.org/jira/browse/FLINK-9862?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16552571#comment-16552571
 ] 

ASF GitHub Bot commented on FLINK-9862:
---------------------------------------

Github user tzulitai commented on a diff in the pull request:

    https://github.com/apache/flink/pull/6351#discussion_r204342877
  
    --- Diff: 
flink-end-to-end-tests/flink-datastream-allround-test/src/main/java/org/apache/flink/streaming/tests/SequenceGeneratorSource.java
 ---
    @@ -197,6 +210,11 @@ public void 
initializeState(FunctionInitializationContext context) throws Except
                        for (KeyRangeStates keyRange : snapshotKeyRanges.get()) 
{
                                keyRanges.add(keyRange);
                        }
    +
    +                   // let event time start from the max of all event time 
progress across subtasks in the last execution
    +                   for (Long lastEventTime : lastEventTimes.get()) {
    +                           monotonousEventTime = 
Math.max(monotonousEventTime, lastEventTime);
    --- End diff --
    
    actually, watermarks are not the direct concern here.
    What this piece of change is doing is just to ensure that all subtasks 
start from an event time that is guaranteed to have not "jump back" in time.
    
    Watermark extraction is not done within the source.


> Update end-to-end test to use RocksDB backed timers
> ---------------------------------------------------
>
>                 Key: FLINK-9862
>                 URL: https://issues.apache.org/jira/browse/FLINK-9862
>             Project: Flink
>          Issue Type: Sub-task
>          Components: State Backends, Checkpointing, Streaming
>    Affects Versions: 1.6.0
>            Reporter: Till Rohrmann
>            Assignee: Tzu-Li (Gordon) Tai
>            Priority: Blocker
>              Labels: pull-request-available
>             Fix For: 1.6.0
>
>
> We should add or modify an end-to-end test to use RocksDB backed timers.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to