[jira] [Commented] (FLINK-9846) Add a Kafka table sink factory

[ASF GitHub Bot (JIRA)]

    [ 
https://issues.apache.org/jira/browse/FLINK-9846?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16552642#comment-16552642
 ] 

ASF GitHub Bot commented on FLINK-9846:
---------------------------------------

Github user pnowojski commented on a diff in the pull request:

    https://github.com/apache/flink/pull/6387#discussion_r204351288
  
    --- Diff: 
flink-connectors/flink-connector-kafka-base/src/main/java/org/apache/flink/streaming/connectors/kafka/KafkaTableSourceSinkFactoryBase.java
 ---
    @@ -125,89 +131,47 @@
     
        @Override
        public StreamTableSource<Row> createStreamTableSource(Map<String, 
String> properties) {
    -           final DescriptorProperties params = new 
DescriptorProperties(true);
    -           params.putProperties(properties);
    +           final DescriptorProperties descriptorProperties = 
getValidatedProperties(properties);
    --- End diff --
    
    +1 for this changes here :)


> Add a Kafka table sink factory
> ------------------------------
>
>                 Key: FLINK-9846
>                 URL: https://issues.apache.org/jira/browse/FLINK-9846
>             Project: Flink
>          Issue Type: New Feature
>          Components: Table API &amp; SQL
>            Reporter: Timo Walther
>            Assignee: Timo Walther
>            Priority: Major
>              Labels: pull-request-available
>
> FLINK-8866 implements a unified way of creating sinks and using the format 
> discovery for searching for formats (FLINK-8858). It is now possible to add a 
> Kafka table sink factory for streaming environment that uses the new 
> interfaces.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)