Github user yanghua commented on a diff in the pull request:
https://github.com/apache/flink/pull/6382#discussion_r204369826
--- Diff:
flink-libraries/flink-table/src/test/scala/org/apache/flink/table/expressions/ScalarFunctionsTest.scala
---
@@ -2063,6 +2063,22 @@ class ScalarFunctionsTest extends
ScalarTypesTestBase {
expectedSha256)
}
+ @Test
+ def testCrc32(): Unit = {
+ val expectedCrc32 = "3632233996"
+ testAllApis(
+ "test".crc32(),
+ "crc32('test')",
+ "CRC32('test')",
+ expectedCrc32)
+
+ testAllApis(
+ 'f33.crc32(),
+ "crc32(f33)",
+ "CRC32(f33)",
+ "null")
--- End diff --
I think add more test case, for example :
```
testAllApis(
'f33.crc32(),
"f33.crc32()",
"CRC32(f33)",
"null")
```
looks better to me.
---
