[ 
https://issues.apache.org/jira/browse/FLINK-9931?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16554256#comment-16554256
 ] 

ASF GitHub Bot commented on FLINK-9931:
---------------------------------------

Github user zentol commented on a diff in the pull request:

    https://github.com/apache/flink/pull/6400#discussion_r204758822
  
    --- Diff: 
flink-runtime/src/main/java/org/apache/flink/runtime/rest/handler/legacy/metrics/JobVertexMetricsHandler.java
 ---
    @@ -28,15 +35,21 @@
      * {@code {"available": [ { "name" : "X", "id" : "X" } ] } }
      *
      * <p>If the query parameters do contain a "get" parameter, a 
comma-separated list of metric names is expected as a value.
    - * {@code /metrics?get=X,Y}
    + * {@code /metrics?get=X,Y OR /metrics?get=X,Y&&subtasks=0-4,7-10}
      * The handler will then return a list containing the values of the 
requested metrics.
      * {@code [ { "id" : "X", "value" : "S" }, { "id" : "Y", "value" : "T" } ] 
}
      *
      * @deprecated This class is subsumed by {@link SubtaskMetricsHandler} and 
is only kept for backwards-compatibility.
      */
     @Deprecated
     public class JobVertexMetricsHandler extends AbstractMetricsHandler {
    +   private final Logger log = LoggerFactory.getLogger(getClass());
    --- End diff --
    
    either add this as a protected field to the `AbstractMetricsHandler`, or 
change it to being static.


> watermark display bug.
> ----------------------
>
>                 Key: FLINK-9931
>                 URL: https://issues.apache.org/jira/browse/FLINK-9931
>             Project: Flink
>          Issue Type: Bug
>          Components: Webfrontend
>    Affects Versions: 1.5.1
>            Reporter: luojiangyu
>            Priority: Major
>              Labels: pull-request-available
>
> If the parallelism of the operator is bigger, the request url of watermark 
> may access the limit of the length of http url, it results in watermark 
> display bug.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to