GitHub user GJL opened a pull request:
https://github.com/apache/flink/pull/6406
[FLINK-9159][runtime] Sanity check default timeout values
## What is the purpose of the change
*Set the default timeouts for resource release to sane values. Consolidate
config keys and documentation.*
## Brief change log
- *Set default value of `mesos.failover-timeout` to 1 week.*
- *Deprecate config key `slotmanager.request-timeout`*
## Verifying this change
This change added tests and can be verified as follows:
- *Added test `SlotManagerConfigurationTest` to verify that slot request
timeouts are set correctly.*
- *Manually deployed on Mesos 1.5.0.*
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (yes / **no**)
- The public API, i.e., is any changed class annotated with
`@Public(Evolving)`: (**yes** / no)
- The serializers: (yes / **no** / don't know)
- The runtime per-record code paths (performance sensitive): (yes /
**no** / don't know)
- Anything that affects deployment or recovery: JobManager (and its
components), Checkpointing, Yarn/Mesos, ZooKeeper: (**yes** / no / don't know)
- The S3 file system connector: (yes / **no** / don't know)
## Documentation
- Does this pull request introduce a new feature? (yes / **no**)
- If yes, how is the feature documented? (**not applicable** / docs /
JavaDocs / not documented)
cc: @tillrohrmann
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/GJL/flink FLINK-9159
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/6406.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #6406
----
commit 96ef18e322c5623a609382057985b35971ba3234
Author: gyao <gary@...>
Date: 2018-07-24T13:38:47Z
[FLINK-9159][mesos] Set default value of mesos.failover-timeout to 1 week.
commit 112122912d7dd78c612c1648f3e2b041ae65afa6
Author: gyao <gary@...>
Date: 2018-07-24T13:48:27Z
[FLINK-9159][runtime] Deprecate config key slotmanager.request-timeout
- Replace config key slotmanager.request-timeout with slot.request.timeout
because
both keys have effectively the same semantics.
- Rename key slotmanager.taskmanager-timeout to
resourcemanager.taskmanager-timeout.
commit 787f7c1480a5676e7ce52092265b3cd051064e3c
Author: gyao <gary@...>
Date: 2018-07-24T13:55:16Z
[hotfix][docs] Add -DskipTests flag to command that generates docs.
----
---
