Github user twalthr commented on a diff in the pull request:

    https://github.com/apache/flink/pull/6391#discussion_r204757871
  
    --- Diff: 
flink-connectors/flink-connector-elasticsearch-base/src/main/java/org/apache/flink/streaming/connectors/elasticsearch/ElasticsearchApiCallBridge.java
 ---
    @@ -39,23 +38,25 @@
      * exactly one instance of the call bridge, and state cleanup is performed 
when the sink is closed.
      */
     @Internal
    -public interface ElasticsearchApiCallBridge extends Serializable {
    +public abstract class ElasticsearchApiCallBridge implements Serializable {
    --- End diff --
    
    Parameterize the class instead of using `AutoClosable` as a synonym for the 
a client that implements this interface. This avoids manual casting in 
subclasses.


---

Reply via email to