Github user tzulitai commented on a diff in the pull request:

    https://github.com/apache/flink/pull/6391#discussion_r205031956
  
    --- Diff: 
flink-connectors/flink-connector-elasticsearch6/src/test/java/org/apache/flink/streaming/connectors/elasticsearch/EmbeddedElasticsearchNodeEnvironmentImpl.java
 ---
    @@ -0,0 +1,82 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + *    http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.flink.streaming.connectors.elasticsearch;
    +
    +import 
org.apache.flink.streaming.connectors.elasticsearch6.ElasticsearchSinkITCase;
    +
    +import org.elasticsearch.client.Client;
    +import org.elasticsearch.common.network.NetworkModule;
    +import org.elasticsearch.common.settings.Settings;
    +import org.elasticsearch.node.InternalSettingsPreparer;
    +import org.elasticsearch.node.Node;
    +import org.elasticsearch.plugins.Plugin;
    +import org.elasticsearch.transport.Netty4Plugin;
    +
    +import java.io.File;
    +import java.util.Collections;
    +
    +/**
    + * Implementation of {@link EmbeddedElasticsearchNodeEnvironment} for 
Elasticsearch 6.
    + * Will be dynamically loaded in {@link ElasticsearchSinkITCase} for 
integration tests.
    + */
    +public class EmbeddedElasticsearchNodeEnvironmentImpl implements 
EmbeddedElasticsearchNodeEnvironment {
    +
    +   private Node node;
    +
    +   @Override
    +   public void start(File tmpDataFolder, String clusterName) throws 
Exception {
    +           if (node == null) {
    +                   Settings settings = Settings.builder()
    +                           .put("cluster.name", clusterName)
    +                           .put("http.enabled", false)
    +                           .put("path.home", tmpDataFolder.getParent())
    +                           .put("path.data", 
tmpDataFolder.getAbsolutePath())
    +                           .put(NetworkModule.HTTP_TYPE_KEY, 
Netty4Plugin.NETTY_HTTP_TRANSPORT_NAME)
    --- End diff --
    
    You're right, removed.


---

Reply via email to