Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/6415#discussion_r205070634
--- Diff: flink-end-to-end-tests/test-scripts/test_ha_dataset.sh ---
@@ -0,0 +1,139 @@
+#!/usr/bin/env bash
+################################################################################
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+################################################################################
+
+source "$(dirname "$0")"/common.sh
+
+TEST_PROGRAM_JAR=${END_TO_END_DIR}/flink-dataset-allround-test/target/DataSetAllroundTestProgram.jar
+
+JM_WATCHDOG_PID=0
+
+# flag indicating if we have already cleared up things after a test
+CLEARED=0
+
+function stop_cluster_and_watchdog() {
+ if [ ${CLEARED} -eq 0 ]; then
+
+ if ! [ ${JM_WATCHDOG_PID} -eq 0 ]; then
+ echo "Killing JM watchdog @ ${JM_WATCHDOG_PID}"
+ kill ${JM_WATCHDOG_PID} 2> /dev/null
+ wait ${JM_WATCHDOG_PID} 2> /dev/null
+ fi
+
+ CLEARED=1
+ fi
+}
+
+function verify_logs() {
--- End diff --
move into shared `common-ha.sh`, parameterized the strings to search for so
it's also applicable for the streaming test.
---
