zentol commented on a change in pull request #6416: [FLINK-9942][rest] Guard
handlers against null fields
URL: https://github.com/apache/flink/pull/6416#discussion_r205132806
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/rest/messages/job/JobSubmitRequestBody.java
##########
@@ -34,7 +35,7 @@
*/
public final class JobSubmitRequestBody implements RequestBody {
- private static final String FIELD_NAME_JOB_GRAPH = "jobGraphFileName";
+ public static final String FIELD_NAME_JOB_GRAPH = "jobGraphFileName";
Review comment:
That would _work_ but probably wouldn't return a useful error message.
Generally speaking I'd prefer if by default all fields are required (which
was also the case at some point), waiting for @GJL response on why that was
changed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
