[
https://issues.apache.org/jira/browse/FLINK-9944?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16555840#comment-16555840
]
ASF GitHub Bot commented on FLINK-9944:
---------------------------------------
zentol commented on a change in pull request #6421: [FLINK-9944][tests] Cleanup
end-to-end test poms
URL: https://github.com/apache/flink/pull/6421#discussion_r205158644
##########
File path: flink-end-to-end-tests/flink-bucketing-sink-test/pom.xml
##########
@@ -72,30 +66,15 @@
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-shade-plugin</artifactId>
- <version>3.0.0</version>
<executions>
<execution>
+
<id>BucketingSinkTestProgram</id>
Review comment:
There are multiple benefits to introducing an explicit id.
They reduce the chance for clashes between executions, as executions without
IDs are treated as a single execution.
The ID is printed when the shade-plugin is executed, which makes it easier
to associate the output to a specific shade-plugin execution.
Finally, with newer maven versions you can invoke specific executions.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Cleanup end-to-end test poms
> ----------------------------
>
> Key: FLINK-9944
> URL: https://issues.apache.org/jira/browse/FLINK-9944
> Project: Flink
> Issue Type: Improvement
> Components: Build System, Tests
> Affects Versions: 1.6.0
> Reporter: Chesnay Schepler
> Assignee: Chesnay Schepler
> Priority: Major
> Labels: pull-request-available
> Fix For: 1.6.0
>
>
> The poms for the various end-to-end modules require some attention.
> We can streamline the shade-plugin configuration by moving common elements to
> the parent pom.
> Most modules explicitly depend on flink-core; in the spirit of being similar
> to quickstart projects (i.e. the template for user-jars) we should remove
> this dependency. It is transitively pulled in by the API modules flink-java
> and flink-streaming-java.
> Other problems:
> * several flink dependencies are not set to provided
> * the datastream-allround-test has a hard-coded scala version in it's rocksdb
> dependency.
> * The ttl test depends on rocksdb but doesn't actually use it
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
