twalthr commented on a change in pull request #6432: [FLINK-9970] Add ASCII
function for table/sql API
URL: https://github.com/apache/flink/pull/6432#discussion_r205512482
##########
File path:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/functions/ScalarFunctions.scala
##########
@@ -196,6 +196,19 @@ object ScalarFunctions {
new String(data)
}
+ /**
+ * Returns the numeric value of the leftmost character of the string str.
+ * Returns 0 if str is the empty string. Returns NULL if str is NULL.
+ */
+ def ascii(str: String): String = {
+ if (str == null)
+ null
+ else if (str.equals(""))
+ ""
+ else
+ str.charAt(0).toInt.toString
Review comment:
Java is UTF-16. The result is wrong.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
