[
https://issues.apache.org/jira/browse/FLINK-9970?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16558471#comment-16558471
]
ASF GitHub Bot commented on FLINK-9970:
---------------------------------------
twalthr commented on a change in pull request #6432: [FLINK-9970] Add ASCII
function for table/sql API
URL: https://github.com/apache/flink/pull/6432#discussion_r205511293
##########
File path: docs/dev/table/sql.md
##########
@@ -1842,6 +1842,16 @@ RPAD(text string, len integer, pad string)
<tr>
<td>
{% highlight text %}
+ASCII(text string)
+{% endhighlight %}
+ </td>
+ <td>
+ <p>Returns the numeric value of the leftmost character of the string
str. Returns 0 if str is the empty string. Returns NULL if str is NULL. E.g.
<code>ASCII('THIS')</code> returns <code>84</code>.</p>
Review comment:
Please do not copy documentation from other projects. Especially if other
projects are not Apache licensed. Even worse than copying is copying but not
adjusting variable names. You use `text string` in the paramter but `str` in
the description.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Add ASCII function for table/sql API
> ------------------------------------
>
> Key: FLINK-9970
> URL: https://issues.apache.org/jira/browse/FLINK-9970
> Project: Flink
> Issue Type: New Feature
> Components: Table API & SQL
> Reporter: vinoyang
> Assignee: vinoyang
> Priority: Minor
> Labels: pull-request-available
>
> refer to :
> https://dev.mysql.com/doc/refman/8.0/en/string-functions.html#function_ascii
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
