zentol commented on issue #6437: [FLINK-9976][streaming] Remove unnecessary 
generic parameters
URL: https://github.com/apache/flink/pull/6437#issuecomment-408370024
 
 
   I think that would be a nicer approach. The fact that this compiles _and 
runs without error_ is rather disgusting:
   ```
   final RowFormatBuilder<String, String> original = forRowFormat(new 
Path("test"), (Encoder<String>) (element, stream) -> stream.write(0));
   final RowFormatBuilder<String, Integer> casted = original
        .withBucketerAndPolicy(new Bucketer<String, Integer>() {
                @Override
                public Integer getBucketId(String element, Context context) {
                        return 0;
                }
   
                @Override
                public SimpleVersionedSerializer<Integer> getSerializer() {
                        return null;
                }
        }, new RollingPolicy<String, Integer>() {
                @Override
                public boolean shouldRollOnCheckpoint(PartFileInfo<Integer> 
partFileState) throws IOException {
                        return false;
                }
   
                @Override
                public boolean shouldRollOnEvent(PartFileInfo<Integer> 
partFileState, String element) throws IOException {
                        return false;
                }
   
                @Override
                public boolean shouldRollOnProcessingTime(PartFileInfo<Integer> 
partFileState, long currentTime) throws IOException {
                        return false;
                }
        });
   
   if (!original.equals(casted)) {
        throw new RuntimeException();
   }
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to