[
https://issues.apache.org/jira/browse/FLINK-9958?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16559680#comment-16559680
]
ASF GitHub Bot commented on FLINK-9958:
---------------------------------------
yanghua commented on a change in pull request #6426: [FLINK-9958][DataSet] Fix
potential NPE for delta iteration of DataSet
URL: https://github.com/apache/flink/pull/6426#discussion_r205757315
##########
File path:
flink-optimizer/src/main/java/org/apache/flink/optimizer/plantranslate/JobGraphGenerator.java
##########
@@ -401,6 +402,12 @@ else if (node instanceof SolutionSetPlanNode) {
}
// adjust the driver
+ if
(conf.getDriver().equals(JoinWithSolutionSetFirstDriver.class) ||
conf.getDriver().equals(JoinWithSolutionSetSecondDriver.class)) {
Review comment:
line break after "||" looks better~
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Fix potential NPE for delta iteration of DataSet
> ------------------------------------------------
>
> Key: FLINK-9958
> URL: https://issues.apache.org/jira/browse/FLINK-9958
> Project: Flink
> Issue Type: Bug
> Components: DataSet API
> Reporter: Ruidong Li
> Assignee: Ruidong Li
> Priority: Major
> Labels: pull-request-available
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
