[ 
https://issues.apache.org/jira/browse/FLINK-9987?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Chesnay Schepler updated FLINK-9987:
------------------------------------
    Description: 
The classloading end-to-end test makes use of the {{.version.properties}} file 
that is bundled with flink-runtime to ensure classloading works properly.

In particular it access the {{git.remote.origin.url}} property.

This should be changed since this property isn't stable across builds, which 
results in test failures when running the e2e tests against a release that was 
built on a different machine.

The test furthermore relies on this file also existing in the source 
flink-runtime module, which is a dangerous assumption as this requires 
flink-runtime to be built beforehand. It is also _yet another_ instance where 
we navigate out of a module which should never be done.

  was:
The classloading end-to-end test makes use of the {{.version.properties}} file 
that is bundled with flink-runtime to ensure classloading works properly.

In particular it access the {{git.remote.origin.url}} property.

This should be changed since this property isn't stable across builds, which 
results in test failures when running the e2e tests against a release that was 
built on a different machine.

The test furthermore relies on this file existing in the source flink-runtime 
module, which is a dangerous assumption as this requires flink-runtime to be 
built beforehand. It is also _yet another_ instance where we navigate out of a 
module which should never be done.


> Rework ClassLoaderITCase to not rely on .version.properties file
> ----------------------------------------------------------------
>
>                 Key: FLINK-9987
>                 URL: https://issues.apache.org/jira/browse/FLINK-9987
>             Project: Flink
>          Issue Type: Improvement
>          Components: Tests
>    Affects Versions: 1.5.0, 1.6.0
>            Reporter: Chesnay Schepler
>            Assignee: Chesnay Schepler
>            Priority: Major
>             Fix For: 1.6.0
>
>
> The classloading end-to-end test makes use of the {{.version.properties}} 
> file that is bundled with flink-runtime to ensure classloading works properly.
> In particular it access the {{git.remote.origin.url}} property.
> This should be changed since this property isn't stable across builds, which 
> results in test failures when running the e2e tests against a release that 
> was built on a different machine.
> The test furthermore relies on this file also existing in the source 
> flink-runtime module, which is a dangerous assumption as this requires 
> flink-runtime to be built beforehand. It is also _yet another_ instance where 
> we navigate out of a module which should never be done.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to