[
https://issues.apache.org/jira/browse/FLINK-2479?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14653480#comment-14653480
]
Fabian Hueske edited comment on FLINK-2479 at 8/4/15 11:43 AM:
---------------------------------------------------------------
I think the issue is fine.
Some runtime tests (MergeJoin, HashJoin, ...) use the {{Record}} class. In a
recent [pull request|https://github.com/apache/flink/pull/907] new tests for
outer MergeJoins were added that use the {{TestData}} tools and extended them
to use {{Tuple2<Integer, String>}} types instead of {{Record}}. The remaining
tests, using {{Record}} are not changed and that is what this JIRA is about.
AFAIK, the {{Record}} data type is not going to be removed (it is not
deprecated) but it would be nice to port the tests nonetheless.
was (Author: fhueske):
I think the issue is fine.
Some runtime tests (MergeJoin, HashJoin, ...) use the {{Record}} class. In a
recent [pull request](https://github.com/apache/flink/pull/907) new tests for
outer MergeJoins were added that use the {{TestData}} tools and extended them
to use {{Tuple2<Integer, String>}} types instead of {{Record}}. The remaining
tests, using {{Record}} are not changed and that is what this JIRA is about.
AFAIK, the {{Record}} data type is not going to be removed (it is not
deprecated) but it would be nice to port the tests nonetheless.
> Refactoring of org.apache.flink.runtime.operators.testutils.TestData class
> --------------------------------------------------------------------------
>
> Key: FLINK-2479
> URL: https://issues.apache.org/jira/browse/FLINK-2479
> Project: Flink
> Issue Type: Task
> Components: Local Runtime
> Reporter: Ricky Pogalz
> Priority: Minor
> Fix For: pre-apache
>
>
> Currently, there are still tests which use {{Record}} from the old record
> API. One of the test util classes is {{TestData}}, including {{Generator}}
> and some other classes still using {{Record}}. An alternative implementation
> of the {{Generator}} without {{Record}} already exists in the {{TestData}}
> class, namely {{TupleGenerator}}.
> Please replace the utility classes in {{TestData}} that still use {{Record}}
> and adapt all of its usages.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
