[
https://issues.apache.org/jira/browse/FLINK-9240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16560853#comment-16560853
]
ASF GitHub Bot commented on FLINK-9240:
---------------------------------------
chunjef opened a new pull request #6446: [FLINK-9240] Avoid deprecated Akka
methods
URL: https://github.com/apache/flink/pull/6446
## What is the purpose of the change
This PR replaces the Akka methods that were deprecated in Akka 2.4 with
their respective non-deprecated alternatives. Since [Akka 2.5 is backwards
binary compatible with
2.4](https://doc.akka.io/docs/akka/2.5/common/binary-compatibility-rules.html)
(except the deprecated methods, which were removed in 2.5), this change would
allow Flink users to use Akka 2.5 without resorting to dependency shading to
avoid classpath conflicts with Flink's use of Akka 2.4.
## Brief change log
- Replaced the use of `ActorSystem.awaitTermination()` with
`Await.ready(system.whenTerminated, Duration.Inf)`
- Replaced the use of `ActorSystem.awaitTermination(timeout)` with
`Await.ready(system.whenTerminated, timeout)`
- Replaced the use of `ActorSystem.isTerminated` with
`ActorSystem.whenTerminated.isCompleted`
- Replaced the use of `ActorSystem.shutdown()` with `ActorSystem.terminate()`
## Verifying this change
This change is already covered by existing tests.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): no
- The public API, i.e., is any changed class annotated with
`@Public(Evolving)`: no
- The serializers: no
- The runtime per-record code paths (performance sensitive): no
- Anything that affects deployment or recovery: JobManager (and its
components), Checkpointing, Yarn/Mesos, ZooKeeper: yes
- The S3 file system connector: no
## Documentation
- Does this pull request introduce a new feature? no
- If yes, how is the feature documented? not applicable
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Avoid deprecated akka methods
> -----------------------------
>
> Key: FLINK-9240
> URL: https://issues.apache.org/jira/browse/FLINK-9240
> Project: Flink
> Issue Type: Improvement
> Components: Client, Local Runtime, Mesos, Tests, Web Client, YARN
> Affects Versions: 1.6.0
> Reporter: Arnout Engelen
> Priority: Minor
> Labels: pull-request-available
>
> Several Akka functions that are widely-used in Flink have been deprecated for
> a long time, such as ActorSystem#shutdown() and
> ActorSystem.awaitTermination(). It would be nice to update those to use
> non-deprecated functions.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
