[ 
https://issues.apache.org/jira/browse/FLINK-9926?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16562725#comment-16562725
 ] 

ASF GitHub Bot commented on FLINK-9926:
---------------------------------------

glaksh100 commented on issue #6427: [FLINK-9926][Kinesis Connector] Allow for 
ShardConsumer override in Kinesis consumer.
URL: https://github.com/apache/flink/pull/6427#issuecomment-409059743
 
 
   +1 from my side. LGTM.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Allow for ShardConsumer override in Kinesis consumer
> ----------------------------------------------------
>
>                 Key: FLINK-9926
>                 URL: https://issues.apache.org/jira/browse/FLINK-9926
>             Project: Flink
>          Issue Type: Task
>          Components: Kinesis Connector
>            Reporter: Thomas Weise
>            Assignee: Thomas Weise
>            Priority: Minor
>              Labels: pull-request-available
>
> There are various reasons why the user may want to override the consumer. 
> Examples are to optimize the run loop or to add additional metrics or 
> logging. Instead of baking the constructor into runFetcher, create a 
> customizable factory method.
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to