[ 
https://issues.apache.org/jira/browse/FLINK-6810?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16563646#comment-16563646
 ] 

Fabian Hueske commented on FLINK-6810:
--------------------------------------

Hi [~hequn8128], thanks for adding contribution instructions! That's a great 
idea. I'll add another point about testing. Thanks, Fabian

> Add Some built-in Scalar Function supported
> -------------------------------------------
>
>                 Key: FLINK-6810
>                 URL: https://issues.apache.org/jira/browse/FLINK-6810
>             Project: Flink
>          Issue Type: New Feature
>          Components: Table API & SQL
>    Affects Versions: 1.4.0
>            Reporter: sunjincheng
>            Assignee: sunjincheng
>            Priority: Major
>              Labels: starter
>
> In this JIRA, will create some sub-task for add specific scalar function, 
> such as mathematical-function {{LOG}}, date-functions
>  {{DATEADD}},string-functions {{LPAD}}, etc. 
> *How To Contribute a build-in scalar function*
> Thank you very much for contributing a build-in function. In order to make 
> sure your contributions are in a good direction, it is recommended to read 
> the following instructions.
> # Research the behavior of the function which you are going to contribute in 
> major DBMSs. This is very import since we have to understand the exact 
> semantics of the function.
> # It is recommended to add function both for sql and talbe-api.
> # Every scalar function should add TableAPI docs in  
> {{./docs/dev/table/tableApi.md#built-in-functions}}. Add SQL docs in 
> {{./docs/dev/table/sql.md#built-in-functions}}. When add docs for table-api, 
> you should add both scala docs and java docs. Make sure your description of 
> the function is accurate. Please do not copy documentation from other 
> projects. Especially if other projects are not Apache licensed.
> # Take overflow, NullPointerException and other exceptions into consideration.
> Welcome anybody to add the sub-task about standard database scalar function.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to