tzulitai commented on a change in pull request #6440: [FLINK-9979] [table]
Support a FlinkKafkaPartitioner for Kafka table sink factory
URL: https://github.com/apache/flink/pull/6440#discussion_r206767191
##########
File path:
flink-connectors/flink-connector-kafka-0.10/src/main/java/org/apache/flink/streaming/connectors/kafka/Kafka010TableSink.java
##########
@@ -51,11 +52,11 @@ public Kafka010TableSink(
String topic,
Properties properties,
SerializationSchema<Row> serializationSchema,
- FlinkKafkaPartitioner<Row> partitioner) {
+ Optional<FlinkKafkaPartitioner<Row>> partitioner) {
return new FlinkKafkaProducer010<>(
topic,
serializationSchema,
properties,
- partitioner);
+ partitioner.orElse(null));
Review comment:
Why is the default here `null`, while for the JSON table sink it is the
`FlinkFixedPartitioner`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
